Add output query chunk size as temporary env variable #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeastplume
added a commit
to yeastplume/grin-wallet
that referenced
this pull request
Jan 17, 2020
yeastplume
added a commit
that referenced
this pull request
Jan 17, 2020
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the hardcoded 200 in the default node client's
get_outputsquery to optionally use an environment variable, so users have a lever with which to try to address URI length restrictions in their environments.Note this is done as an environment variable as opposed to a configuration setting, as this is only intended to be a temporary workaround. The move to using the node's JSON-RPC API will happen on or before 4.0.0 and should address the root of this issue properly (by including the list of outputs to fetch in the body instead of as a query string).