Change check_repair + certain functions to lock more granularly #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeastplume
changed the title
…quired for new wallets
yeastplume
changed the title
|
This is ready for review now if anyone wants to take a look |
yyangli
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
May 13, 2020
…lewimble#252) * Rename check-repair -> scan, make lock logic more granular * rustfmt * update owner api implementations where to allow granular locking where required * rustfmt * store init state on startup to determine whether full utxo scan is required for new wallets * rustfmt * fix for init status persist * add start height argument to scan * rustfmt
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
…lewimble#252) * Rename check-repair -> scan, make lock logic more granular * rustfmt * update owner api implementations where to allow granular locking where required * rustfmt * store init state on startup to determine whether full utxo scan is required for new wallets * rustfmt * fix for init status persist * add start height argument to scan * rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support changes in mimblewimble/grin-rfcs#30, this PR aims to:
check_repairtoscanscanimplementation to lock wallet contents a more granular level, freeing up the ability for other threads to run against the wallet while a scan is running.scanto also lock at a more granular level.restorefunction in favor of the singlescanfunction.scancommand to optionally accept a start block height for the scan