Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.0 TX log entries backwards compatibility fix #242

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

yeastplume
Copy link
Member

Fixes backwards compatibility issue discovered when sending to Poloniex with a 2.1.0 wallet. New fields being read from the DB didn't have a Serde default and were silently returning no transaction data when querying transactions created in < 2.1.0

yeastplume added a commit to yeastplume/grin-wallet that referenced this pull request Oct 17, 2019
@yeastplume yeastplume mentioned this pull request Oct 17, 2019
@yeastplume yeastplume added the bug Something isn't working label Oct 17, 2019
@yeastplume yeastplume added this to the 2.1.0 milestone Oct 17, 2019
@yeastplume yeastplume merged commit 28739e6 into mimblewimble:current/2.1.x Oct 17, 2019
yeastplume added a commit that referenced this pull request Oct 17, 2019
@yeastplume yeastplume deleted the tx_log_issue branch October 21, 2019 12:45
yyangli pushed a commit to mwcproject/mwc-wallet that referenced this pull request May 13, 2020
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant