use explicit protocol version (local is not safe) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge this now - we need to explicitly define |
yyangli
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
May 13, 2020
…to_version use explicit protocol version (local is not safe)
antiochp
added a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
…to_version use explicit protocol version (local is not safe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit tricky.
A 2.1.0 node uses protocol version 2 internally via
ProtocolVersion::local().But for backward compatibility expects txs via the push api (from the wallet) in proto version 1.
Building grin-wallet pulls in
serfrom node repo.So we cannot use
ProtocolVersion::local()in the wallet repo.This only surfaced as an issue once we tagged node and wallet repos and started building against these.