Remove callbacks from transaction API functions #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyyu
added a commit
to garyyu/grin-wallet
that referenced
this pull request
Jun 24, 2019
* V2 slate versioning enablement (mimblewimble#85) * fix for command line listener port override * reduce parameter query size * Add slate versioning * rustfmt * bump version number * Add tests for slate version conversion * rustfmt * Updates and test addition based on bdap's review * rustfmt * fix mimblewimble#88 (mimblewimble#89) * Add `check_version` function to Foreign API (mimblewimble#87) * move api deser types into separate types mod * rustfmt * missing types file * make all exports from libwallet more explicit * rustfmt * add version check function to foreign api * rustfmt * change check_version return value to result, for consistency * Revert "Merge branch 'master' into master" This reverts commit a63f2c7, reversing changes made to d774272. * [WIP] Invoiced Transactions API Support (mimblewimble#90) * basic invoiced tx working * rustfmt * teardown * rustfmt * rename, new struct for invoice args, begin to add new functions to RPC apis * rustfmt * add fns to rpc api * rustfmt * owner api functions RPC documentation in place * rustfmt * doctests for new invoicing functions * rustfmt * test fixes * update documentation and doctests * rustfmt * invoice testing verification of tx log output * rustfmt * Add Azure Pipelines to grin-wallet * Remove cursive and fix task names * Do not crash on empty terminal * Add LLVM * Possible MSFT pipeline bug with . task * Change connection name * Command line implementation of invoice commands (mimblewimble#96) * add issue_invoice_tx command * rustfmt * add first pass at process_invoice command * start of process_invoice fn * rustfmt * rename issue invoice and process invoice to invoice and pay * add prompting and display information to pay invoice command * rustfmt * support invoice transactions in finalize command * rustfmt * Add Azure Pipelines badge * Remove duplicate LMDB wallet backend code (mimblewimble#101) * remove leftover wallet lmdb code * rustfmt * Simplify slate (de)serialization (mimblewimble#103) * Simplify slate (de)serialization * rustfmt * Cleanup * Fix slate version tests * Another fix for tests * Fix slate deser in http adapter * docstring update and provide a bit of a readme (mimblewimble#104) * Updates for 1.1.0-beta.3 release (mimblewimble#106) * bump version number and build from tag for beta 3 release * update for latest grin tag * Fix keybase adapter (mimblewimble#107) * fix version string in yml (mimblewimble#113) * fix: invoice transaction pay need update the slate height (mimblewimble#115) * Remove double json encoding on http response (mimblewimble#114) * Add participant ID as part of key to stored private transaction context data (mimblewimble#117) * add participant_id to saved tranasction context data * rustfmt? * change participant id for command line pay command * change the api repository to grin-wallet instead of grin (mimblewimble#118) * Test (mimblewimble#119) * Remove Travis.yml (mimblewimble#124) * Version Info API Function tweak, remove 'min_compat_version' from slate (mimblewimble#123) * change slate version function to return list of supported slate formats * rustfmt * remove min_compat_version * Changes for 1.1.0 -> 2.0.0 Deployment strategy decisions (mimblewimble#126) * make slate v0 the default for regular sends * add block_header_version to slate * update doc tests for latest grin version * rustfmt * HACF if HF height detected * rustfmt * version bump for beta.4 * cargo.lock crate version update, and remove 3 build warning from cargo 1.35.0 * Fix for API secret on node API startup (mimblewimble#131) * fix for api_secret when reading node height * rustfmt * remove macro export * trigger ci again * More helpful error message on recover when `wallet_data` dir doesn't exist (mimblewimble#134) * make recover error message when wallet doesn't exist more helpful * rustfmt * fixes and version update for final 1.0.0 build * fixes and version update for final 1.0.0 build * rustfmt * get back the travis-ci scripts * fix the test
yyangli
referenced
this pull request
in mwcproject/mwc-wallet
May 13, 2020
* remove callbacks from transaction creation * rustfmt * add missing functions to owner api rpc * comment fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
initiate_txandreceive_txwere returning callbacks that locked the wallet outputs. To support compatibility with json-rpc interface, changed this callback to be a regular function that gets info from the already stored context instead.Also added RPC wrappers for
initiate_txandtx_lock_outputs.