default to using a Plain kernel with no lock_height #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently default to generating
HeightLocked
transaction kernels (locked at current block height).This PR changes this to default to generating
Plain
transaction kernels.We are exploring making the lock_height optional on kernels (it is not included in the tx kernel hash for
Plain
kernels).First step toward making them truly optional is to stop using them where we don't need to.
Eventually we will be able to reduce storage and bandwidth costs (a little) by only including the
lock_height
onHeightLocked
kernels.This PR leverages the existing grin behavior - a
Plain
tx kernel default to alock_height
of 0 (as we need something to store in the u64 lock_height). This is excluded from the kernel hash forPlain
kernels.TODO -
Plain
kernels are usable across all wallet and node scenarios.