Skip to content

Commit

Permalink
Do not prompt for password to start owner API (#656)
Browse files Browse the repository at this point in the history
* Do not prompt for password to start owner API

It makes no sense to ask for the password if one only wants to initialize the APIs. Asking for the password makes things unnecessarily difficult and insecure in case I, as a system administrator, want to have the APIs running as a system service.

* Update wallet_args.rs

* Update wallet_args.rs

opening wallet if password argument is present

* Update wallet_args.rs
  • Loading branch information
davidtavarez authored Jul 12, 2022
1 parent 95bb4c4 commit b45802a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/cmd/wallet_args.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1037,10 +1037,10 @@ where
("recover", _) => open_wallet = false,
("cli", _) => open_wallet = false,
("owner_api", _) => {
// If wallet exists, open it. Otherwise, that's fine too.
// If wallet exists and password is present then open it. Otherwise, that's fine too.
let mut wallet_lock = wallet.lock();
let lc = wallet_lock.lc_provider().unwrap();
open_wallet = lc.wallet_exists(None)?;
open_wallet = wallet_args.is_present("pass") && lc.wallet_exists(None)?;
}
_ => {}
}
Expand Down

0 comments on commit b45802a

Please sign in to comment.