Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add funding transparency logs #70

Merged
merged 5 commits into from
Mar 4, 2019
Merged

Conversation

lehnberg
Copy link
Collaborator

@lehnberg lehnberg commented Mar 1, 2019

This PR implements logs that will support funding transparency reports.

Specifically, it:

  1. Gives each decision log entry a unique ID (to make it easy to reference);
  2. Adds a financials/income_log.csv, with the first entry being today's donation from Minerbabe;
  3. Adds a financials/spending_log.csv, with the first entry being today's 30% advance to Coinspect for the security audits;

edit: updating based on feedback below.

@ignopeverell
Copy link
Contributor

I wouldn't entirely discount the possibility of one activity or another, directly related to grin, that would generate revenue. Bad example but example nonetheless: auctioning the genesis block reward. So perhaps rename the donation log to revenue log and indicate in it whether it's a donation?

@lehnberg
Copy link
Collaborator Author

lehnberg commented Mar 2, 2019

good point @ignopeverell, that's now been updated

@0xmichalis
Copy link
Contributor

0xmichalis commented Mar 2, 2019

Should we do the same thing for spending? The security audit payment is not a donation to Coinspect but paying @antiochp for 3 months is a donation, right?

@lehnberg
Copy link
Collaborator Author

lehnberg commented Mar 2, 2019

Hmm. Not sure. What would the purpose be? Ie why is it meaningful to distinguish between “donations” and other types of spends?

@0xmichalis
Copy link
Contributor

Hmm. Not sure. What would the purpose be? Ie why is it meaningful to distinguish between “donations” and other types of spends?

I don't have a legal background but based on the last gov meeting, we decided to call payments to devs such as Antioch as a donation vs a contract - see discussion starting from https://gitter.im/grin_community/Lobby?at=5c755d2147276019e981b200

@lehnberg
Copy link
Collaborator Author

lehnberg commented Mar 2, 2019

Yes I’m aware. But what is the reason to distinguish the spend as such compared to other spends? The reason we would do it on the income side is because donations would affect friends of grin whilst other income would not. How is this distinction meaningful on the spend side?

@0xmichalis
Copy link
Contributor

The sentiment in the meeting was uncertainty around legal/tax matters, that's why I think the distinction was made. It may not matter at all in the end.

@lehnberg lehnberg merged commit b3183d4 into mimblewimble:master Mar 4, 2019
@lehnberg lehnberg deleted the financials branch March 4, 2019 10:04
@lehnberg
Copy link
Collaborator Author

lehnberg commented Mar 4, 2019

@Kargakis let's keep an eye on it, it's an easy add in the future. merging this for now.

@0xmichalis
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants