Fix for issue #163 #185
Merged
Fix for issue #163 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue #163. The local variable was not at kernel function scope as required in the OpenCL spec. https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/local.html Quote: "if (...) { // example of variable in __local address space but not // declared at __kernel function scope. local float c; // not allowed. }"
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local variable was not at kernel function scope as required in the OpenCL spec.
https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/local.html
Quote:
"if (...) { // example of variable in __local address space but not // declared at __kernel function scope. local float c; // not allowed. }"
Note:
I also had to symlink the ROCm OpenCL lib to build since it wasn't in /usr/lib/ where it's expected.
sudo ln -s /opt/rocm/opencl/lib/x86_64/libOpenCL.so /usr/lib/libOpenCL.so