Skip to content

enhance: move sent first timeticksync, make recovery more easier#41405

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
chyezh:enhance_move_send_first_timeticksync
Apr 21, 2025
Merged

enhance: move sent first timeticksync, make recovery more easier#41405
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
chyezh:enhance_move_send_first_timeticksync

Conversation

@chyezh
Copy link
Copy Markdown
Contributor

@chyezh chyezh commented Apr 18, 2025

issue: #38399

@sre-ci-robot sre-ci-robot requested review from xige-16 and zwd1208 April 18, 2025 08:35
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Apr 18, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 18, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 74.78261% with 29 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (6fa68c1) to head (bd1cbc9).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...l/streamingnode/server/wal/adaptor/initializing.go 64.70% 19 Missing and 5 partials ⚠️
...nternal/streamingnode/server/wal/adaptor/opener.go 25.00% 2 Missing and 1 partial ⚠️
...al/streamingnode/server/wal/adaptor/wal_adaptor.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41405      +/-   ##
==========================================
- Coverage   81.70%   80.47%   -1.23%     
==========================================
  Files        1175     1488     +313     
  Lines      182063   211189   +29126     
==========================================
+ Hits       148750   169957   +21207     
- Misses      27150    35074    +7924     
+ Partials     6163     6158       -5     
Components Coverage Δ
Client 79.59% <ø> (ø)
Core 72.66% <75.00%> (∅)
Go 81.95% <79.23%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
...mingnode/server/flusher/flusherimpl/wal_flusher.go 68.21% <100.00%> (ø)
...treamingnode/server/wal/adaptor/scanner_adaptor.go 90.06% <100.00%> (+2.39%) ⬆️
...ingnode/server/wal/interceptors/flusher/builder.go 100.00% <100.00%> (ø)
...eamingnode/server/wal/interceptors/redo/builder.go 100.00% <100.00%> (ø)
...ingnode/server/wal/interceptors/segment/builder.go 100.00% <100.00%> (ø)
...interceptors/segment/segment_assign_interceptor.go 59.03% <100.00%> (ø)
...ngnode/server/wal/interceptors/timetick/builder.go 100.00% <100.00%> (ø)
.../wal/interceptors/timetick/timetick_interceptor.go 61.87% <100.00%> (+0.75%) ⬆️
...al/interceptors/timetick/timetick_sync_operator.go 79.78% <100.00%> (+5.31%) ⬆️
...al/streamingnode/server/wal/adaptor/wal_adaptor.go 91.51% <84.61%> (+0.49%) ⬆️
... and 2 more

... and 346 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chyezh chyezh force-pushed the enhance_move_send_first_timeticksync branch from 6110fd3 to ea38cc3 Compare April 20, 2025 06:43
@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the enhance_move_send_first_timeticksync branch from ea38cc3 to bd1cbc9 Compare April 20, 2025 15:03
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@chyezh
Copy link
Copy Markdown
Contributor Author

chyezh commented Apr 21, 2025

rerun cpp-unit-test

@chyezh
Copy link
Copy Markdown
Contributor Author

chyezh commented Apr 21, 2025

rerun go-sdk

@mergify mergify bot added the ci-passed label Apr 21, 2025
@czs007
Copy link
Copy Markdown
Collaborator

czs007 commented Apr 21, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 9339bcc into milvus-io:master Apr 21, 2025
19 of 20 checks passed
@chyezh chyezh deleted the enhance_move_send_first_timeticksync branch April 21, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants