Skip to content

Support crt client master#41381

Closed
MrPresent-Han wants to merge 2 commits intomilvus-io:masterfrom
MrPresent-Han:support-crt-client-master
Closed

Support crt client master#41381
MrPresent-Han wants to merge 2 commits intomilvus-io:masterfrom
MrPresent-Han:support-crt-client-master

Conversation

@MrPresent-Han
Copy link
Copy Markdown
Contributor

@MrPresent-Han MrPresent-Han commented Apr 17, 2025

related: #40525

@sre-ci-robot
Copy link
Copy Markdown
Contributor

sre-ci-robot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/compilation labels Apr 17, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2025

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Apr 17, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2025

@MrPresent-Han

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

czs007
czs007 reviewed Apr 17, 2025
View reviewed changes
internal/core/thirdparty/milvus-storage/CMakeLists.txt
set( milvus-storage_VERSION d143229 )
set( GIT_REPOSITORY "https://github.com/milvus-io/milvus-storage.git")
set( milvus-storage_VERSION a8b4f84)
set( GIT_REPOSITORY "https://github.com/MrPresent-Han/milvus-storage.git")
Copy link
Copy Markdown
Collaborator

@czs007 czs007 Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use private repo

Copy link
Copy Markdown
Contributor Author

@MrPresent-Han MrPresent-Han Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/just for temporary test

@MrPresent-Han
Copy link
Copy Markdown
Contributor Author

MrPresent-Han commented Apr 18, 2025

/hold

@MrPresent-Han MrPresent-Han force-pushed the support-crt-client-master branch from c628cd6 to e2aefd6 Compare April 18, 2025 07:28
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-crt-client-master branch from e2aefd6 to 144ffc7 Compare April 21, 2025 02:12
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@MrPresent-Han
Copy link
Copy Markdown
Contributor Author

MrPresent-Han commented Apr 21, 2025

/run-cpu-e2e

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-crt-client-master branch from 144ffc7 to 2d17785 Compare April 24, 2025 09:22
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 24, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 24, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 24, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.69%. Comparing base (e56adc1) to head (2d17785).
Report is 219 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41381      +/-   ##
==========================================
+ Coverage   80.45%   81.69%   +1.23%     
==========================================
  Files        1493     1181     -312     
  Lines      212393   183303   -29090     
==========================================
- Hits       170873   149741   -21132     
+ Misses      35316    27358    -7958     
  Partials     6204     6204
Components Coverage Δ
Client 79.01% <ø> (ø)
Core ∅ <ø> (∅)
Go 81.94% <ø> (+0.01%) ⬆️

see 341 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stale
Copy link
Copy Markdown

stale bot commented May 24, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label May 24, 2025
@stale stale bot closed this May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czs007 czs007 czs007 left review comments

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

No one assigned

Labels

area/compilation do-not-merge/hold do-not-merge/invalid-pr-format needs-dco DCO is missing in this pull request. size/XL Denotes a PR that changes 500-999 lines. stale indicates no udpates for 30 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrPresent-Han @sre-ci-robot @czs007