Skip to content

fix: transaction should retry if transaction is expired#41379

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
chyezh:fix_transaction_should_retry_if_balance
Apr 20, 2025
Merged

fix: transaction should retry if transaction is expired#41379
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
chyezh:fix_transaction_should_retry_if_balance

Conversation

@chyezh
Copy link
Contributor

@chyezh chyezh commented Apr 17, 2025

issue: #41248

Signed-off-by: chyezh <chyezh@outlook.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 17, 2025
@sre-ci-robot sre-ci-robot requested review from cydrain and xige-16 April 17, 2025 07:54
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 17, 2025
@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Apr 17, 2025

/run-cpu-e2e

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.61%. Comparing base (6a9ecb7) to head (e323b18).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/distributed/streaming/util.go 70.58% 4 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (73.68%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41379       +/-   ##
===========================================
+ Coverage   72.62%   80.61%    +7.99%     
===========================================
  Files         312     1478     +1166     
  Lines       29015   210175   +181160     
===========================================
+ Hits        21072   169440   +148368     
- Misses       7943    34600    +26657     
- Partials        0     6135     +6135     
Components Coverage Δ
Client 79.59% <ø> (∅)
Core 72.62% <ø> (ø)
Go 82.01% <73.68%> (∅)
Files with missing lines Coverage Δ
...ernal/util/streamingutil/status/streaming_error.go 88.00% <100.00%> (ø)
internal/distributed/streaming/util.go 90.40% <70.58%> (ø)

... and 1164 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Apr 17, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Apr 20, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 78fca7e into milvus-io:master Apr 20, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants