Skip to content

fix: solve incompitable problem for none-encoding index(#40838)#41369

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
MrPresent-Han:compitable-master
Apr 20, 2025
Merged

fix: solve incompitable problem for none-encoding index(#40838)#41369
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
MrPresent-Han:compitable-master

Conversation

@MrPresent-Han
Copy link
Copy Markdown
Contributor

related: #40838

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 17, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (1a35374) to head (9e57b76).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/indexbuilder/index_c.cpp 0.00% 4 Missing ⚠️
internal/core/src/storage/Util.cpp 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41369      +/-   ##
==========================================
+ Coverage   80.58%   80.59%   +0.01%     
==========================================
  Files        1478     1478              
  Lines      210153   210197      +44     
==========================================
+ Hits       169354   169413      +59     
+ Misses      34656    34642      -14     
+ Partials     6143     6142       -1     
Components Coverage Δ
Client 79.59% <ø> (ø)
Core 72.65% <75.00%> (+0.02%) ⬆️
Go 81.98% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/storage/IndexData.cpp 86.20% <100.00%> (+0.49%) ⬆️
internal/core/src/storage/PayloadReader.h 100.00% <100.00%> (+23.52%) ⬆️
internal/core/src/storage/Types.h 41.89% <ø> (ø)
internal/datacoord/index_engine_version_manager.go 92.59% <100.00%> (+1.28%) ⬆️
internal/datacoord/server.go 73.91% <100.00%> (+0.03%) ⬆️
internal/datacoord/task_index.go 80.68% <100.00%> (+0.68%) ⬆️
internal/querynodev2/server.go 78.09% <100.00%> (+0.05%) ⬆️
internal/util/sessionutil/session_util.go 76.27% <100.00%> (+0.11%) ⬆️
pkg/common/common.go 79.01% <ø> (ø)
internal/core/src/storage/Util.cpp 79.92% <90.00%> (+0.03%) ⬆️
... and 1 more

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Apr 17, 2025
@czs007
Copy link
Copy Markdown
Collaborator

czs007 commented Apr 20, 2025

/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 016920b into milvus-io:master Apr 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants