Skip to content

enhance: Remove not inuse binlog iterator#41359

Merged
sre-ci-robot merged 2 commits intomilvus-io:masterfrom
XuanYang-cn:rm-binlog-iter
Apr 24, 2025
Merged

enhance: Remove not inuse binlog iterator#41359
sre-ci-robot merged 2 commits intomilvus-io:masterfrom
XuanYang-cn:rm-binlog-iter

Conversation

@XuanYang-cn
Copy link
Copy Markdown
Contributor

@XuanYang-cn XuanYang-cn commented Apr 16, 2025

See also: #41466

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Apr 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 16, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 16, 2025

@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.48%. Comparing base (5219d9a) to head (d4080c5).
Report is 17 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41359      +/-   ##
==========================================
- Coverage   80.48%   80.48%   -0.01%     
==========================================
  Files        1488     1487       -1     
  Lines      211245   211215      -30     
==========================================
- Hits       170017   169992      -25     
+ Misses      35061    35054       -7     
- Partials     6167     6169       +2     
Components Coverage Δ
Client 79.01% <ø> (ø)
Core 72.67% <ø> (+0.01%) ⬆️
Go 81.98% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/storage/data_codec.go 76.56% <ø> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Apr 21, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 23, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Copy Markdown
Contributor Author

/rerun-cpu-e2e

@XuanYang-cn
Copy link
Copy Markdown
Contributor Author

/run-cpu-e2e

@tedxu
Copy link
Copy Markdown
Contributor

tedxu commented Apr 24, 2025

/lgtm

@tedxu
Copy link
Copy Markdown
Contributor

tedxu commented Apr 24, 2025

/approve

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5404560 into milvus-io:master Apr 24, 2025
20 checks passed
@XuanYang-cn XuanYang-cn deleted the rm-binlog-iter branch April 24, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants