Skip to content

fix: catchup scan never done if wal truncate#41345

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
chyezh:catchup_can_never_done_if_wal_truncate
Apr 20, 2025
Merged

fix: catchup scan never done if wal truncate#41345
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
chyezh:catchup_can_never_done_if_wal_truncate

Conversation

@chyezh
Copy link
Contributor

@chyezh chyezh commented Apr 16, 2025

issue: #41062

Signed-off-by: chyezh <chyezh@outlook.com>
@sre-ci-robot sre-ci-robot requested review from xige-16 and zwd1208 April 16, 2025 07:16
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (1d564a2) to head (43e2412).
Report is 25 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41345      +/-   ##
==========================================
- Coverage   80.58%   80.57%   -0.01%     
==========================================
  Files        1476     1476              
  Lines      209861   209884      +23     
==========================================
- Hits       169111   169110       -1     
- Misses      34615    34635      +20     
- Partials     6135     6139       +4     
Components Coverage Δ
Client 79.59% <ø> (ø)
Core 72.38% <ø> (+0.01%) ⬆️
Go 81.98% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...treamingnode/server/wal/adaptor/scanner_adaptor.go 87.75% <100.00%> (+0.08%) ⬆️
...al/streamingnode/server/wal/adaptor/wal_adaptor.go 92.16% <100.00%> (ø)
...erver/wal/interceptors/timetick/inspector/impls.go 100.00% <100.00%> (ø)
...er/wal/interceptors/timetick/inspector/notifier.go 100.00% <100.00%> (ø)
...al/interceptors/timetick/timetick_sync_operator.go 71.80% <100.00%> (-2.66%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Apr 16, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Apr 20, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit ef4923e into milvus-io:master Apr 20, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants