Skip to content

fix: [2.5] Update logging context and upgrade dependencies #41319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025

Conversation

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file area/test sig/testing labels Apr 15, 2025
Copy link
Contributor

mergify bot commented Apr 15, 2025

@SimFG Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels Apr 15, 2025
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 15, 2025
Copy link
Contributor

mergify bot commented Apr 15, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 15, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 64.40129% with 110 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (8b3353c) to head (6406106).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/parser/planparserv2/operators.go 50.00% 7 Missing ⚠️
internal/parser/planparserv2/parser_visitor.go 56.25% 7 Missing ⚠️
internal/proxy/util.go 70.00% 6 Missing ⚠️
internal/distributed/proxy/httpserver/utils.go 0.00% 5 Missing ⚠️
internal/storage/data_codec.go 50.00% 5 Missing ⚠️
pkg/util/indexparams/index_params.go 28.57% 5 Missing ⚠️
internal/storage/field_value.go 55.55% 4 Missing ⚠️
pkg/util/funcutil/policy.go 0.00% 4 Missing ⚠️
internal/parser/planparserv2/utils.go 72.72% 3 Missing ⚠️
internal/util/segcore/reduce.go 40.00% 3 Missing ⚠️
... and 48 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #41319      +/-   ##
==========================================
- Coverage   80.83%   80.75%   -0.09%     
==========================================
  Files        1421     1424       +3     
  Lines      203714   204074     +360     
==========================================
+ Hits       164667   164790     +123     
- Misses      33247    33500     +253     
+ Partials     5800     5784      -16     
Components Coverage Δ
Client 79.65% <0.00%> (ø)
Core 70.66% <ø> (ø)
Go 82.73% <64.82%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 93.41% <100.00%> (ø)
internal/datacoord/index_service.go 90.46% <100.00%> (ø)
internal/datacoord/stats_task_meta.go 86.45% <ø> (ø)
internal/datacoord/task_stats.go 87.32% <100.00%> (ø)
...ternal/datanode/compaction/clustering_compactor.go 66.45% <100.00%> (ø)
internal/distributed/proxy/listener_manager.go 77.70% <100.00%> (ø)
internal/distributed/proxy/service.go 84.90% <100.00%> (ø)
internal/flushcommon/syncmgr/sync_manager.go 90.78% <100.00%> (ø)
internal/kv/tikv/txn_tikv.go 83.24% <100.00%> (ø)
internal/metastore/kv/rootcoord/kv_catalog.go 77.33% <100.00%> (ø)
... and 99 more

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

mergify bot commented Apr 15, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

Copy link
Contributor

mergify bot commented Apr 17, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 18, 2025

@SimFG Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Apr 18, 2025
Copy link
Contributor

mergify bot commented Apr 18, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 18, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Apr 22, 2025
Copy link
Contributor

mergify bot commented Apr 22, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 22, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 22, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 22, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 23, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 23, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added this to the 2.5.11 milestone Apr 23, 2025
liliuleo

This comment was marked as off-topic.

@sre-ci-robot
Copy link
Contributor

@liliuleo: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, liliuleo, SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [liliu-z,xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 18eb627 into milvus-io:2.5 Apr 24, 2025
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants