Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Escape prefix before search in inverted index (#37925) #38425

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: Escape prefix before search in inverted index (#37925) #38425

merged 2 commits into from
Dec 16, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Dec 13, 2024

issue: #37912
pr: #37925

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
add dep
a0f4687 
Signed-off-by: sunby <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.58%. Comparing base (d7e926f) to head (a0f4687).
Report is 13 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38425      +/-   ##
==========================================
- Coverage   79.45%   70.58%   -8.88%     
==========================================
  Files        1077     1077              
  Lines      169024   170167    +1143     
==========================================
- Hits       134300   120109   -14191     
- Misses      30260    45594   +15334     
  Partials     4464     4464

see 294 files with indirect coverage changes

@sunby
Copy link
Contributor Author

sunby commented Dec 16, 2024

/run-cpu-e2e

@sunby sunby closed this Dec 16, 2024
@sunby sunby reopened this Dec 16, 2024
@sunby
Copy link
Contributor Author

sunby commented Dec 16, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 16, 2024
congqixia
congqixia approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit aad59b8 into milvus-io:2.4 Dec 16, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunby @sre-ci-robot @congqixia