Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add detail, replica count for resource group #38315

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 9, 2024

issue: #30647
pr: #38314

@sre-ci-robot sre-ci-robot requested review from xige-16 and yah01 December 9, 2024 12:42
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 9, 2024
Signed-off-by: chyezh <[email protected]>
@mergify mergify bot added the ci-passed label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (0c442b6) to head (c364ada).
Report is 25 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38315      +/-   ##
==========================================
+ Coverage   80.41%   80.42%   +0.01%     
==========================================
  Files        1074     1077       +3     
  Lines      168774   169330     +556     
==========================================
+ Hits       135716   136181     +465     
- Misses      28615    28684      +69     
- Partials     4443     4465      +22     
Files with missing lines Coverage Δ
internal/querycoordv2/meta/replica_manager.go 82.73% <100.00%> (+0.52%) ⬆️
internal/querycoordv2/meta/resource_manager.go 82.76% <100.00%> (+0.57%) ⬆️
pkg/metrics/metrics.go 100.00% <ø> (ø)
pkg/metrics/querycoord_metrics.go 100.00% <100.00%> (ø)
pkg/metrics/querynode_metrics.go 100.00% <ø> (ø)

... and 75 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed lgtm size/M Denotes a PR that changes 30-99 lines. labels Dec 13, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Dec 13, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1da4ac4 into milvus-io:2.4 Dec 13, 2024
15 checks passed
@chyezh chyezh deleted the enhance_resource_group_monitor_2_4 branch December 14, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants