Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SyncSegments rpc always failed #38032

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: SyncSegments rpc always failed #38032

merged 1 commit into from
Nov 28, 2024
+2 −2

Conversation

weiliu1031
Copy link
Contributor

issue: #38031
cause call cli.SyncSegments use ctx which already be override and canceled, so SyncSegments rpc will always failed.

@weiliu1031
fix: SyncSegments rpc always failed
a1d6c2e 
cause call `cli.SyncSegments` use ctx which already be override and
canceled, so SyncSegments rpc will always failed.

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 26, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Nov 26, 2024
@weiliu1031
Copy link
Contributor Author

/kind branch-feature

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (93063ce) to head (a1d6c2e).
Report is 14 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/session_manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38032      +/-   ##
==========================================
- Coverage   72.34%   72.29%   -0.05%     
==========================================
  Files        1070     1070              
  Lines      167427   167428       +1     
==========================================
- Hits       121130   121050      -80     
- Misses      41892    41950      +58     
- Partials     4405     4428      +23
Files with missing lines Coverage Δ
internal/datacoord/session_manager.go 68.02% <0.00%> (-0.97%) ⬇️

... and 43 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 27, 2024
@xiaocai2333
Copy link
Contributor

don't set timeout for sync segments. see #34291

@xiaocai2333
Copy link
Contributor

/lgtm

congqixia
congqixia approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 88b731d into milvus-io:2.4 Nov 28, 2024
13 of 15 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Dec 19, 2024
@congqixia @weiliu1031
fix: SyncSegments rpc always failed
519800b 
miss the patch due to code branching
previous pr: milvus-io#38032

Co-authored-by: Wei Liu <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Dec 19, 2024
Merged
congqixia pushed a commit to congqixia/milvus that referenced this pull request Dec 19, 2024
@weiliu1031 @congqixia
fix: SyncSegments rpc always failed (milvus-io#38032)
8066726 
issue: milvus-io#38031
cause call `cli.SyncSegments` use ctx which already be override and
canceled, so SyncSegments rpc will always failed.

Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Dec 19, 2024
Merged
czs007 pushed a commit that referenced this pull request Dec 19, 2024
@congqixia @weiliu1031
fix: [10kcp] SyncSegments rpc always failed (#38032) (#38579)
f5ae24f 
Cherry-pick from 2.4
pr: #38032
issue: #38031
cause call `cli.SyncSegments` use ctx which already be override and
canceled, so SyncSegments rpc will always failed.

Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Co-authored-by: wei liu <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Dec 19, 2024
@congqixia @weiliu1031
fix: SyncSegments rpc always failed (#38578)
3d360c0 
miss the patch due to code branching
previous pr: #38032

Signed-off-by: Congqi Xia <[email protected]>
Co-authored-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@xiaocai2333 xiaocai2333

Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliu1031 @xiaocai2333 @sre-ci-robot @congqixia