Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[2.4]GrowingDataGetter get the wrong string data #37995

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Nov 25, 2024

issue: #37994
master pr: #38015

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@cqy123456
Copy link
Contributor Author

/hold

Copy link
Contributor

mergify bot commented Nov 25, 2024

@cqy123456 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Nov 25, 2024
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 26, 2024
@cqy123456
Copy link
Contributor Author

/unhold

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (4aca68a) to head (7e4677d).
Report is 13 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/core/src/query/GroupByOperator.h 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37995      +/-   ##
==========================================
+ Coverage   72.24%   72.30%   +0.05%     
==========================================
  Files        1069     1070       +1     
  Lines      166979   167428     +449     
==========================================
+ Hits       120641   121060     +419     
- Misses      41919    41942      +23     
- Partials     4419     4426       +7     
Files with missing lines Coverage Δ
internal/core/src/query/GroupByOperator.h 0.00% <0.00%> (ø)

... and 53 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 26, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 48fe9db into milvus-io:2.4 Nov 26, 2024
13 of 15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants