Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Handle the error of the compaction queue being full #37990

Merged

Conversation

xiaocai2333
Copy link
Contributor

issue: #37988

master pr: #37989

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (93063ce) to head (f92d4ec).
Report is 15 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 25.00% 13 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37990      +/-   ##
==========================================
+ Coverage   72.34%   80.60%   +8.26%     
==========================================
  Files        1070     1070              
  Lines      167427   167443      +16     
==========================================
+ Hits       121130   134974   +13844     
+ Misses      41892    28035   -13857     
- Partials     4405     4434      +29     
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 76.79% <25.00%> (-0.98%) ⬇️

... and 242 files with indirect coverage changes

@xiaocai2333 xiaocai2333 force-pushed the handle_compaction_enqueue_err-4 branch from 004cdbd to f92d4ec Compare November 26, 2024 02:33
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007 czs007 added this to the 2.4.18 milestone Nov 26, 2024
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 26, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 045cf56 into milvus-io:2.4 Nov 29, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants