Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Remove unnecessary segment clone updating dist (#37797) #37833

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #37797
Related to #37630

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Nov 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 20, 2024
@congqixia congqixia added the 10kcp PR related to 10k collection partitions Project label Nov 20, 2024
Copy link
Contributor

mergify bot commented Nov 20, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.29%. Comparing base (cffde80) to head (f62a9c2).
Report is 2 commits behind head on 2.4.

❗ There is a different number of reports uploaded between BASE (cffde80) and HEAD (f62a9c2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cffde80) HEAD (f62a9c2)
2 1
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37833      +/-   ##
==========================================
- Coverage   80.65%   72.29%   -8.36%     
==========================================
  Files        1069     1069              
  Lines      166972   166972              
==========================================
- Hits       134669   120715   -13954     
- Misses      27908    41855   +13947     
- Partials     4395     4402       +7     
Files with missing lines Coverage Δ
internal/querycoordv2/dist/dist_handler.go 95.94% <100.00%> (ø)

... and 240 files with indirect coverage changes

---- 🚨 Try these New Features:

@mergify mergify bot added the ci-passed label Nov 20, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Nov 20, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 20, 2024
@sre-ci-robot sre-ci-robot merged commit 28adfe4 into milvus-io:2.4 Nov 20, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants