Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Provide secondary index criteria when filter leaderview (#37777) #37802

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #37777
Related to #37630


@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 19, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 19, 2024
Copy link
Contributor

mergify bot commented Nov 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (a10f95d) to head (f7580df).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37802      +/-   ##
==========================================
- Coverage   80.69%   79.67%   -1.03%     
==========================================
  Files        1069     1069              
  Lines      166969   166975       +6     
==========================================
- Hits       134729   133029    -1700     
- Misses      27860    29531    +1671     
- Partials     4380     4415      +35     
Files with missing lines Coverage Δ
...rnal/querycoordv2/observers/collection_observer.go 86.63% <100.00%> (+0.10%) ⬆️
internal/querycoordv2/task/action.go 96.29% <100.00%> (+0.05%) ⬆️
internal/querycoordv2/task/scheduler.go 88.93% <100.00%> (-0.41%) ⬇️

... and 100 files with indirect coverage changes

---- 🚨 Try these New Features:

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 19, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 19, 2024
@congqixia congqixia added 10kcp PR related to 10k collection partitions Project manual-pass manually set pass before ci-passed labeled labels Nov 20, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 0bd2617 into milvus-io:2.4 Nov 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants