Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Remove unnecessary clone in SetState #37736

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #37637

pr: #37697

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (cdf703a) to head (969eb45).
Report is 13 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37736      +/-   ##
==========================================
- Coverage   80.65%   80.62%   -0.03%     
==========================================
  Files        1069     1069              
  Lines      166900   166896       -4     
==========================================
- Hits       134605   134564      -41     
- Misses      27902    27921      +19     
- Partials     4393     4411      +18     
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.45% <100.00%> (ø)
internal/datacoord/segment_info.go 84.72% <ø> (-1.58%) ⬇️

... and 35 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d295735 into milvus-io:2.4 Nov 16, 2024
15 checks passed
@congqixia congqixia added the 10kcp PR related to 10k collection partitions Project label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants