Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make GetShardLeaders only retries on retriable error #37687

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #37532
pr: #37684

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.60%. Comparing base (d23da2d) to head (852794a).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37687      +/-   ##
==========================================
+ Coverage   72.31%   80.60%   +8.28%     
==========================================
  Files        1069     1069              
  Lines      166879   166879              
==========================================
+ Hits       120681   134506   +13825     
+ Misses      41801    27954   -13847     
- Partials     4397     4419      +22     
Files with missing lines Coverage Δ
internal/proxy/lb_policy.go 97.90% <100.00%> (ø)

... and 230 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Nov 14, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Nov 14, 2024
@sre-ci-robot sre-ci-robot merged commit c50cb8d into milvus-io:2.4 Nov 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants