Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add cgo call metrics for load/write API (#37405) #37627

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #37405

Cgo API cost is not observerable since not metrics is related to them. This PR add metrics for some sync cgo call related to load & write


Cgo API cost is not observerable since not metrics is related to them.
This PR add metrics for some sync cgo call related to load & write

---------

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 13, 2024
@sre-ci-robot sre-ci-robot requested review from aoiasd and sunby November 13, 2024 02:02
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.27%. Comparing base (25c9699) to head (7933eba).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37627      +/-   ##
==========================================
- Coverage   79.65%   72.27%   -7.39%     
==========================================
  Files        1069     1069              
  Lines      166729   166777      +48     
==========================================
- Hits       132816   120530   -12286     
- Misses      29507    41848   +12341     
+ Partials     4406     4399       -7     
Files with missing lines Coverage Δ
internal/querynodev2/segments/load_index_info.go 28.98% <100.00%> (+4.37%) ⬆️
internal/querynodev2/segments/segment.go 67.76% <100.00%> (+0.96%) ⬆️
pkg/metrics/metrics.go 100.00% <ø> (ø)
pkg/metrics/querynode_metrics.go 100.00% <100.00%> (ø)

... and 257 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit d073f32 into milvus-io:2.4 Nov 13, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants