-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [cp24]Correct varchar primarykey size calculation #37619
fix: [cp24]Correct varchar primarykey size calculation #37619
Conversation
See also: milvus-io#37582 pr: milvus-io#37617 Signed-off-by: yangxuan <[email protected]>
/lgtm |
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn E2e jenkins job failed, comment |
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #37619 +/- ##
==========================================
+ Coverage 72.26% 79.70% +7.43%
==========================================
Files 1069 1069
Lines 166880 166879 -1
==========================================
+ Hits 120598 133011 +12413
+ Misses 41867 29462 -12405
+ Partials 4415 4406 -9
|
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, xiaofan-luan, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also: #37582
pr: #37617