-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Search may return less result after qn recover (#36549) #37610
Conversation
@weiliu1031 E2e jenkins job failed, comment |
issue: milvus-io#36293 milvus-io#36242 after qn recover, delegator may be loaded in new node, after all segment has been loaded, delegator becomes serviceable. but delegator's target version hasn't been synced, and if search/query comes, delegator will use wrong target version to filter out a empty segment list, which caused empty search result. This pr will block delegator's serviceable status until target version is synced --------- Signed-off-by: Wei Liu <[email protected]>
f8606d8
to
bf962a0
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #37610 +/- ##
==========================================
- Coverage 80.60% 80.59% -0.01%
==========================================
Files 1069 1069
Lines 166736 166731 -5
==========================================
- Hits 134392 134374 -18
- Misses 27935 27947 +12
- Partials 4409 4410 +1
|
issue: #36293 #36242
pr: #36549
after qn recover, delegator may be loaded in new node, after all segment has been loaded, delegator becomes serviceable. but delegator's target version hasn't been synced, and if search/query comes, delegator will use wrong target version to filter out a empty segment list, which caused empty search result.
This pr will block delegator's serviceable status until target version is synced