Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search may return less result after qn recover (#36549) #37610

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #36293 #36242
pr: #36549
after qn recover, delegator may be loaded in new node, after all segment has been loaded, delegator becomes serviceable. but delegator's target version hasn't been synced, and if search/query comes, delegator will use wrong target version to filter out a empty segment list, which caused empty search result.

This pr will block delegator's serviceable status until target version is synced


@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 12, 2024
Copy link
Contributor

mergify bot commented Nov 12, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

issue: milvus-io#36293 milvus-io#36242
after qn recover, delegator may be loaded in new node, after all segment
has been loaded, delegator becomes serviceable. but delegator's target
version hasn't been synced, and if search/query comes, delegator will
use wrong target version to filter out a empty segment list, which
caused empty search result.

This pr will block delegator's serviceable status until target version
is synced

---------

Signed-off-by: Wei Liu <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Nov 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Nov 12, 2024
@sre-ci-robot sre-ci-robot merged commit 7d1c899 into milvus-io:2.4 Nov 12, 2024
13 checks passed
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (074f8ee) to head (bf962a0).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querycoordv2/observers/target_observer.go 73.68% 6 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37610      +/-   ##
==========================================
- Coverage   80.60%   80.59%   -0.01%     
==========================================
  Files        1069     1069              
  Lines      166736   166731       -5     
==========================================
- Hits       134392   134374      -18     
- Misses      27935    27947      +12     
- Partials     4409     4410       +1     
Files with missing lines Coverage Δ
internal/querycoordv2/dist/dist_controller.go 85.71% <100.00%> (+0.29%) ⬆️
internal/querycoordv2/dist/dist_handler.go 95.79% <100.00%> (+0.43%) ⬆️
internal/querycoordv2/meta/leader_view_manager.go 95.88% <100.00%> (+0.02%) ⬆️
internal/querycoordv2/meta/target_manager.go 90.19% <100.00%> (-0.05%) ⬇️
internal/querycoordv2/server.go 81.97% <100.00%> (+0.13%) ⬆️
internal/querycoordv2/services.go 85.26% <ø> (ø)
internal/querycoordv2/utils/util.go 82.31% <100.00%> (ø)
internal/querycoordv2/observers/target_observer.go 87.07% <73.68%> (+5.99%) ⬆️

... and 25 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants