Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cp24]Change memoryCheck write lock to read lock #37526

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

XuanYang-cn
Copy link
Contributor

pr: #37525

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 8, 2024
Copy link
Contributor

mergify bot commented Nov 8, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 14, 2024
@XuanYang-cn XuanYang-cn changed the title enhance: [cp24]refine some log informations in flush fix: [cp24]Change memoryCheck write lock to read lock Nov 14, 2024
@mergify mergify bot added the kind/bug Issues or changes related a bug label Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.97%. Comparing base (c50cb8d) to head (37ff874).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datanode/writebuffer/manager.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37526      +/-   ##
==========================================
+ Coverage   72.25%   77.97%   +5.71%     
==========================================
  Files        1069     1061       -8     
  Lines      166881   165748    -1133     
==========================================
+ Hits       120588   129250    +8662     
+ Misses      41878    32084    -9794     
+ Partials     4415     4414       -1     
Files with missing lines Coverage Δ
internal/datacoord/services.go 83.74% <100.00%> (-1.51%) ⬇️
internal/datanode/syncmgr/task.go 97.98% <100.00%> (ø)
internal/datanode/writebuffer/manager.go 89.14% <62.50%> (-4.94%) ⬇️

... and 401 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5d5f899 into milvus-io:2.4 Nov 15, 2024
13 of 15 checks passed
@XuanYang-cn XuanYang-cn deleted the cp24/enhance-logs branch November 18, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants