Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add metrics for querynode delete buffer info (#37081) #37097

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #37081
Related to #35303

This PR add metrics for querynode delegator delete buffer information, which is related to dml quota logic.

Related to milvus-io#35303

This PR add metrics for querynode delegator delete buffer information,
which is related to dml quota logic.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot requested review from xige-16 and yah01 October 24, 2024 03:51
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels Oct 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (27a4fe0) to head (e030fc9).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37097      +/-   ##
==========================================
- Coverage   83.72%   80.62%   -3.10%     
==========================================
  Files         798     1066     +268     
  Lines      138606   165082   +26476     
==========================================
+ Hits       116045   133095   +17050     
- Misses      18220    27655    +9435     
+ Partials     4341     4332       -9     
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator.go 86.46% <100.00%> (+0.08%) ⬆️
...odev2/delegator/deletebuffer/list_delete_buffer.go 100.00% <100.00%> (ø)
pkg/metrics/querynode_metrics.go 100.00% <100.00%> (ø)

... and 300 files with indirect coverage changes

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Oct 24, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3db137f into milvus-io:2.4 Oct 24, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/37081 branch October 24, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants