Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] force to stop buffer message when receiving the drop collection message #36917

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Oct 16, 2024

/kind improvement
pr: #36916

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Oct 16, 2024
@sre-ci-robot sre-ci-robot requested review from xige-16 and yhmo October 16, 2024 07:40
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 16, 2024
@SimFG
Copy link
Contributor Author

SimFG commented Oct 16, 2024

rerun ut

@mergify mergify bot added the ci-passed label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (604e346) to head (44c2576).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36917      +/-   ##
==========================================
+ Coverage   71.88%   81.26%   +9.38%     
==========================================
  Files        1064     1064              
  Lines      140851   140854       +3     
==========================================
+ Hits       101251   114467   +13216     
+ Misses      35263    22068   -13195     
+ Partials     4337     4319      -18     
Files with missing lines Coverage Δ
pkg/mq/msgstream/mq_msgstream.go 82.79% <100.00%> (+0.94%) ⬆️

... and 238 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8743752 into milvus-io:2.4 Oct 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants