Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure alias is cached #36808

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

xiaofan-luan
Copy link
Collaborator

see also #36806

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Oct 12, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Oct 12, 2024
Copy link
Contributor

mergify bot commented Oct 12, 2024

@xiaofan-luan Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Oct 12, 2024
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Oct 12, 2024
Copy link
Contributor

mergify bot commented Oct 12, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 12, 2024
@mergify mergify bot added the ci-passed label Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (1d9c746) to head (0d0dac4).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36808      +/-   ##
==========================================
- Coverage   81.23%   81.23%   -0.01%     
==========================================
  Files        1064     1064              
  Lines      140832   140834       +2     
==========================================
- Hits       114404   114400       -4     
- Misses      22091    22093       +2     
- Partials     4337     4341       +4     
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 92.30% <100.00%> (+0.02%) ⬆️

... and 21 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Oct 13, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 44564f0 into milvus-io:2.4 Oct 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants