Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support new RESTful URL to describe import job (#36753) #36754

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

bigsheeper
Copy link
Contributor

Support the new RESTful URL for retrieving/describing import progress: /v2/vectordb/jobs/import/describe.
Deprecate the old URL: /v2/vectordb/jobs/import/get_progress.

issue: #36752

pr: #36753

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 10, 2024
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot added the ci-passed label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (c69af44) to head (c3eb3e2).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36754      +/-   ##
==========================================
+ Coverage   71.95%   81.23%   +9.27%     
==========================================
  Files        1064     1064              
  Lines      140580   140581       +1     
==========================================
+ Hits       101159   114194   +13035     
+ Misses      35093    22050   -13043     
- Partials     4328     4337       +9     
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.81% <100.00%> (+<0.01%) ⬆️

... and 228 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Oct 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7ee46c5 into milvus-io:2.4 Oct 11, 2024
15 checks passed
@czs007 czs007 added this to the 2.4.13 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants