Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [24]Remove neighbors if compactTo is unindexed (#36503) #36694

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #36360
pr: #36503

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 8, 2024
Copy link
Contributor

mergify bot commented Oct 8, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 9, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.20%. Comparing base (6e93601) to head (ad51ac9).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36694      +/-   ##
==========================================
- Coverage   84.94%   81.20%   -3.74%     
==========================================
  Files         797     1064     +267     
  Lines      116067   140495   +24428     
==========================================
+ Hits        98591   114091   +15500     
- Misses      13136    22068    +8932     
+ Partials     4340     4336       -4     
Files with missing lines Coverage Δ
internal/datacoord/handler.go 77.85% <100.00%> (+1.47%) ⬆️
internal/datacoord/segment_info.go 84.68% <ø> (ø)

... and 292 files with indirect coverage changes

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Oct 9, 2024
@sre-ci-robot sre-ci-robot merged commit 0ff8e13 into milvus-io:2.4 Oct 9, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the cp24/fix-split branch October 9, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants