Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] avoid to create many timer object in the target #36573

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Sep 27, 2024

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Sep 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 27, 2024
@SimFG SimFG force-pushed the 2.4 branch 2 times, most recently from 6991d6c to 0e5d8f5 Compare September 29, 2024 02:19
@mergify mergify bot added the ci-passed label Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (e5a6c5b) to head (48952fe).
Report is 5 commits behind head on 2.4.

Files with missing lines Patch % Lines
pkg/util/typeutil/map.go 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36573      +/-   ##
==========================================
- Coverage   71.91%   71.90%   -0.02%     
==========================================
  Files        1064     1064              
  Lines      140331   140408      +77     
==========================================
+ Hits       100925   100956      +31     
- Misses      35089    35120      +31     
- Partials     4317     4332      +15     
Files with missing lines Coverage Δ
pkg/mq/msgdispatcher/target.go 100.00% <100.00%> (ø)
pkg/util/paramtable/base_table.go 81.75% <100.00%> (ø)
pkg/util/typeutil/map.go 90.14% <0.00%> (-9.86%) ⬇️

... and 37 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 58a763c into milvus-io:2.4 Sep 29, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants