Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix term expr overflow bug #36534

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Sep 26, 2024

pr: #36525

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (bdc59f3) to head (bb0cf10).
Report is 12 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/TermExpr.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36534      +/-   ##
==========================================
- Coverage   84.97%   81.08%   -3.89%     
==========================================
  Files         793     1061     +268     
  Lines      115327   140130   +24803     
==========================================
+ Hits        98003   113630   +15627     
- Misses      13035    22180    +9145     
- Partials     4289     4320      +31     
Files with missing lines Coverage Δ
internal/core/src/exec/expression/TermExpr.cpp 83.16% <0.00%> (ø)

... and 316 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9a07c1b into milvus-io:2.4 Sep 28, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants