Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] update the expr version and format the expr http response #36467

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Sep 24, 2024

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 24, 2024
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/dependency Pull requests that update a dependency file labels Sep 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (b92daa1) to head (469b20d).
Report is 7 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/util/flowgraph/node.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36467      +/-   ##
==========================================
- Coverage   81.15%   81.10%   -0.06%     
==========================================
  Files        1060     1060              
  Lines      139759   139762       +3     
==========================================
- Hits       113427   113351      -76     
- Misses      22061    22119      +58     
- Partials     4271     4292      +21     
Files with missing lines Coverage Δ
internal/http/server.go 65.51% <100.00%> (+1.23%) ⬆️
internal/util/flowgraph/node.go 84.15% <0.00%> (ø)

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 24, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6604bbd into milvus-io:2.4 Sep 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants