Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[cherry-pick] Fix compatible ascending index typo #34712

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jul 16, 2024

issue: #34707
pr: #34708

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jul 16, 2024
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 16, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Jul 16, 2024
Copy link
Contributor

mergify bot commented Jul 16, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (64dc848) to head (db7beaa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #34712      +/-   ##
==========================================
+ Coverage   83.02%   83.10%   +0.08%     
==========================================
  Files         851      851              
  Lines      107696   107182     -514     
==========================================
- Hits        89414    89077     -337     
+ Misses      14972    14788     -184     
- Partials     3310     3317       +7     
Files Coverage Δ
internal/proxy/util.go 91.55% <100.00%> (ø)

... and 85 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan
Copy link
Contributor

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 16, 2024
@sre-ci-robot sre-ci-robot merged commit 8e34c4c into milvus-io:2.3 Jul 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants