Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [restful v2] add partition key isolation prop #34710

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Jul 16, 2024

issue: #34332

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jul 16, 2024
@PwzXxm PwzXxm force-pushed the restful_add_iso branch 6 times, most recently from 9037bed to 2b5624a Compare July 18, 2024 02:15
Copy link
Contributor

mergify bot commented Jul 18, 2024

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Jul 18, 2024

rerun ut

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Jul 18, 2024

/run-cpu-e2e

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Jul 19, 2024

rerun ut

@mergify mergify bot added the ci-passed label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (7eaef09) to head (703feaf).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34710      +/-   ##
==========================================
- Coverage   84.46%   80.81%   -3.65%     
==========================================
  Files         904     1175     +271     
  Lines      117777   142106   +24329     
==========================================
+ Hits        99476   114839   +15363     
- Misses      13896    22852    +8956     
- Partials     4405     4415      +10     
Files Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.61% <100.00%> (+0.02%) ⬆️

... and 293 files with indirect coverage changes

@PowderLi
Copy link
Contributor

/lgtm

@czs007
Copy link
Contributor

czs007 commented Jul 22, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 80c0ae3 into milvus-io:master Jul 22, 2024
11 of 12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 22, 2024
issue: #34332
pr: #34710

Signed-off-by: Patrick Weizhi Xu <[email protected]>
(cherry picked from commit 703feaf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants