Fix server readiness for 2.6 tests#123
Conversation
| { | ||
| DateTime before = DateTime.UtcNow; | ||
|
|
||
| await Task.Delay(200); |
There was a problem hiding this comment.
Honestly, I'm a bit confused about this test.
|
@verdie-g isn't this something that should be fixed in the milvus testcontainer itself? It's the testcontainer's responsibility to reliably wait until the service (Milvus in this case) is up and ready to handle requests. Do you want to submit a PR against https://github.com/testcontainers/testcontainers-dotnet/tree/develop/src/Testcontainers.Milvus? |
|
@roji the testcontainer PR was merged. I'm copying its content here until it's released. |
|
@yhmo @xiaofan-luan any idea what the DCO status check is above? It's "waiting for status to be reported" and blocking merging. |
|
https://milvus.io/blog/how-to-contribute-to-milvus-a-quick-start-for-developers.md git commit -m "Commit of your change" -s @verdie-g |
51526d0 to
0cae3b7
Compare
|
Thanks @xiaofan-luan, I've added the signoff but I can still see the "DCO Expected — Waiting for status to be reported". Any idea why? |
8244ead to
aabbc71
Compare
Signed-off-by: Grégoire Verdier <g.verdier@criteo.com>
Signed-off-by: Grégoire Verdier <g.verdier@criteo.com>
Signed-off-by: Grégoire Verdier <g.verdier@criteo.com>
aabbc71 to
a01fc48
Compare
Since #122, v2.6 tests have been failing with Grpc.Core.RpcException : Status(StatusCode="Unknown", Detail="service unavailable: internal: Milvus Proxy is not ready yet. please wait"). The testcontainer is checking /healthz but it seems like it's not enough. The proposed fix is to send some requests until the server is really ready.