Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives Nomad their face back, plus a buncha whiskers #14

Merged
merged 4 commits into from
May 10, 2024

Conversation

Altoids1
Copy link
Collaborator

@Altoids1 Altoids1 commented May 9, 2024

image

Summary

This re-implements Nomad's face and ears, and adds some procedural whiskers, which later can be modified to respond to the environment or something.

Coder warnings

This change required creating a new class, FSpriteNomad, for overriding basic Slugcat sprites with our own ones. I did it that way so that only specifically Nomad slugcats are affected by this mod (so we aren't clobbering the assets of other slugcats). I also had to modify head.txt/face.txt slightly so that their sprites start with the expected "nomad_" prefix; all generic slugcat sprites should follow that naming pattern. head.png was also modified to be white rather than Nomad's colour, to allow for modification of Nomad's colour (for example to convey heat, starvation, etc).

This PR also features a bunch of novel documentation, comments, and some minor refactors, which aren't user-facing but should make it a little easier to understand how Nomad's graphics work.

Changelog

  • Relocated the old DMS sprites, since we no longer have that mod as a dependency
  • Re-implemented Nomad's face and ears
  • Added procedurally-generated whiskers on the sides of Nomad.

Altoids1 added 4 commits May 9, 2024 01:18
These changes are largely irrelevant to this PR (which is about whiskers), I just ended up doing them over the course of getting used to this codebase.
This also features some minor refactors of how NomadGraphics articulates how we determine the number of sprites to allocate for the Slugcat, plus deferring a mysterious TriangleMesh instantiation into a slightly more friendly Util function.
Some of this stuff isn't placed back in yet, nor updated to have the "nomad_" prefix in the atlas thing, and might be useless, but I did want to at least have a move commit to get some visible history going.
No DressMySlugcat dependency required! Heck yeah! >:)
@Altoids1 Altoids1 force-pushed the altoids-whiskers branch from 933a47f to 3fffc51 Compare May 10, 2024 08:37
@Altoids1 Altoids1 marked this pull request as ready for review May 10, 2024 08:45
@Altoids1 Altoids1 changed the title Gives Nomad some whiskers Gives Nomad their face back, plus a buncha whiskers May 10, 2024
@BensoneWhite BensoneWhite merged commit f4cb344 into main May 10, 2024
1 check passed
Altoids1 added a commit that referenced this pull request May 10, 2024
working with two copies of the same thing is making me crazy
@Altoids1 Altoids1 deleted the altoids-whiskers branch May 10, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants