Skip to content

Settings modal and safe local-computer setup - #88

Merged
milind-soni merged 2 commits into
mainfrom
codex/pr-82-integration
Aug 14, 2026
Merged

Settings modal and safe local-computer setup#88
milind-soni merged 2 commits into
mainfrom
codex/pr-82-integration

Conversation

@milind-soni

Copy link
Copy Markdown
Owner

Integrates #82 on current main, with the review findings and cross-platform drift resolved.

  • replace the long settings side panel with an accessible, keyboard-contained sectional modal
  • preserve update download/install behavior and remove the superseded panel
  • detect Docker, Podman, and Apple container runtimes without allowing a stopped Docker install to hide a healthy alternative
  • use Apple container’s actual system status and JSON inspection syntax
  • generate platform-appropriate setup guidance and hide runtime commands until detection succeeds
  • bind VNC/noVNC to loopback only
  • detect old or misconfigured containers with public desktop ports and require a safe recreation instead of reporting them ready
  • prevent overlapping status polls and split shared settings primitives to avoid a circular import
  • add eight focused runtime, command, and network-safety tests

Local verification: 198 tests passed (7 platform-specific skips), typecheck, Electron syntax checks, production build, and a live read-only runtime probe.

Closes #82

milind-soni and others added 2 commits August 14, 2026 08:32
App settings were one long right-hand panel. They are now a modal with a
section list — General, Connections, Local computer — which is where new
settings can go without making one column longer.

The new section sets up a computer your bots can borrow: a Linux desktop
in a container on this machine, free and disposable, separate from your
own desktop and files. It runs the same X11 desktop our computer tools
already speak, so nothing about the tools changes — only where the
commands run.

It is a checklist that watches itself rather than a wall of instructions.
A read-only status endpoint reports which container runtime is installed,
whether its daemon is actually up, whether the image is pulled and
whether the container is running; the panel polls while you work through
the steps and ticks them off. Installed-but-not-running is called out
separately, because that one otherwise fails later and reads as broken —
verified against a real Docker install in exactly that state.

We never tell anyone to install Docker specifically: its licence needs
payment above 250 employees or $10M revenue and for government use, so
the steps suggest Colima or Podman and we adapt to whatever is present.
Nothing here installs anything; it only reports and shows commands.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@milind-soni, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 07fff7e7-bf5e-43f2-a432-ff129524da0a

📥 Commits

Reviewing files that changed from the base of the PR and between f621a6f and 5bfb3b8.

📒 Files selected for processing (8)
  • server/container-computer.test.ts
  • server/container-computer.ts
  • server/index.ts
  • src/App.tsx
  • src/components/AppSettingsPanel.tsx
  • src/components/LocalComputerSection.tsx
  • src/components/SettingsModal.tsx
  • src/components/SettingsPrimitives.tsx

Comment @coderabbitai help to get the list of available commands.

@milind-soni
milind-soni merged commit 5f3af33 into main Aug 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant