Integrate #42: collision-safe Windows permission broker - #83
Conversation
…allowing listen errors
Every permission prompt on Windows silently ends as a deny.
The Claude driver brokers approvals over a unix domain socket in
DATA_DIR and hands that path to the injected MCP permission proxy.
Windows has no unix sockets, so `server.listen()` fails immediately —
and the listener was `server.on("error", () => {})`, so nothing was
logged. The proxy then cannot connect, the ask never reaches the UI,
and the request times out into a deny with no diagnostic anywhere.
net.createServer binds a named pipe under the same API, so
permissionSocketPath returns `\.\pipe\omb-perm-<pid>-<tag>` on win32
and the existing socket path elsewhere. The pipe namespace is global and
flat — DATA_DIR does not isolate it the way it does for socket files —
so the pid is in the name to keep concurrent harnesses off each other.
The error listener now logs instead of discarding: a broker that cannot
come up is worth one line of stderr rather than an unexplained deny.
The test that raises an ask over the socket now asks the driver for the
path instead of rebuilding it, so it follows the platform.
Stacked on the CLI-resolver PR: with both applied the driver test suite
runs unskipped on Windows (89 passed / 3 skipped, from 52/33 on main).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HgJeiantdRcZSBrc5sqqCp
Port the permission broker fix through the centralized named-pipe helper and add collision coverage.
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
2 participants
Ports the remaining #42 permission-broker work onto current
mainafter #41/#81.Local verification: typecheck, Electron syntax validation, production build, and 179 passing tests (seven Windows-only cases skipped locally).
Closes #42.