Skip to content

fix(computer): close VPS viewer review gaps - #484

Merged
milind-soni merged 1 commit into
mainfrom
codex/vps-parity-companion-awake
Aug 26, 2026
Merged

fix(computer): close VPS viewer review gaps#484
milind-soni merged 1 commit into
mainfrom
codex/vps-parity-companion-awake

Conversation

@milind-soni

@milind-soni milind-soni commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

Follow-up to #458 after review identified two still-relevant UI edge cases:

  • release bot control before waiting for best-effort VPS tunnel cleanup, so a stuck cleanup request cannot leave the bot paused
  • replace the stale VPS backend copy with the shipped Auto opt-in and secure live-desktop behavior

The Companion-exit finding from #458 is already covered more comprehensively on current main by the new lifecycle listener, so this follow-up deliberately does not duplicate that implementation.

Verification

  • pnpm typecheck
  • focused VPS renderer test
  • clean rebase on current main

Summary by CodeRabbit

  • New Features

    • Clarified that Auto can create or wake its managed VPS when automatic startup is enabled.
    • Clarified that the live desktop is accessible through the computer panel.
  • Bug Fixes

    • Improved control release and cleanup when opening the desktop viewer fails.

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openmausbot-docs Ready Ready Preview Aug 26, 2026 5:49am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8973ef71-9ec1-486f-8858-c8cab82bf5b7

📥 Commits

Reviewing files that changed from the base of the PR and between 4fcd2b0 and 6a703d3.

📒 Files selected for processing (2)
  • src/components/CloudBackendPicker.tsx
  • src/components/ComputerPanel.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The change updates Auto backend messaging and changes failed viewer handling so bot control is released before VPS tunnel cleanup.

Changes

VPS desktop flow

Layer / File(s) Summary
Auto backend guidance
src/components/CloudBackendPicker.tsx
The Auto-mode description now documents managed VPS creation or waking when automatic startup is enabled. It directs users to the computer panel for live-desktop access.
Viewer failure cleanup
src/components/ComputerPanel.tsx
Failed viewer opens release bot control before best-effort cleanup. Cleanup remains limited to ready VPS sessions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 6a703

This is a localized UI behavior and backend-selection update with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

Suggested reviewers: kesleydavid, bferanmi806-sketch

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the computer UI fix and accurately summarizes the PR's main purpose: closing VPS viewer review gaps.
Description check ✅ Passed The description explains what changed, why the changes were needed, and how the changes were verified. It is mostly complete, although it uses Summary and Verification headings instead of the template…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains what changed, why the changes were needed, and how the changes were verified. It is mostly complete, although it uses Summary and Verification headings instead of the template headings and omits the checklist and UI screenshots section.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/vps-parity-companion-awake

Comment @coderabbitai help to get the list of available commands.

@milind-soni
milind-soni merged commit a682033 into main Aug 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant