feat(computer): open live VNC desktop inside the app - #322
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
milind-soni
marked this pull request as ready for review
August 21, 2026 05:08
kargnas
added a commit
to kargnas/OpenMausBot
that referenced
this pull request
Aug 21, 2026
main의 milind-soni#322(인앱 VNC), milind-soni#250(분석 옵트아웃) 병합 충돌을 해결했다. index.test은 modelSelection 검증 테스트와 팀 프로젝트 임포트 테스트를 모두 유지했다. 새 pi 드라이버는 catalog 계약에 맞춰 default를 {model} 객체로 두고 getter 대신 catalog()를 노출한다. Tested: pnpm typecheck, pnpm vitest run (139 files, 1392 passed, 12 skipped) Confidence: high Scope-risk: moderate Reversability: moderate
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why a native modal
Box documents that authenticated VNC must load as a top-level page. A normal iframe would fail its token exchange, so the Electron modal is its own sandboxed top-level web contents while remaining visually inside the app.
Verification
pnpm buildpnpm typecheckpnpm check:electronpnpm test(1,362 registered tests; broker, updater, viewer security, and packaged-server checks all pass)Manual check
The remaining useful check is opening a real Box desktop and Local VM in a packaged build to confirm provider rendering and platform modal behavior.