Skip to content

feat(computer): open live VNC desktop inside the app - #322

Merged
milind-soni merged 1 commit into
mainfrom
codex/in-app-vnc-control
Aug 21, 2026
Merged

feat(computer): open live VNC desktop inside the app#322
milind-soni merged 1 commit into
mainfrom
codex/in-app-vnc-control

Conversation

@milind-soni

Copy link
Copy Markdown
Owner

What changed

  • opens Box and Local VM live desktops in a sandboxed modal owned by OpenMausBot
  • makes Take control acquire the existing input lock before opening the interactive desktop
  • pauses redundant screenshot polling while the live viewer is open
  • keeps a browser fallback for non-Electron development and viewer load failures
  • isolates remote viewer storage, navigation, and permissions; never persists or logs rotating desktop URLs

Why a native modal

Box documents that authenticated VNC must load as a top-level page. A normal iframe would fail its token exchange, so the Electron modal is its own sandboxed top-level web contents while remaining visually inside the app.

Verification

  • pnpm build
  • pnpm typecheck
  • pnpm check:electron
  • pnpm test (1,362 registered tests; broker, updater, viewer security, and packaged-server checks all pass)

Manual check

The remaining useful check is opening a real Box desktop and Local VM in a packaged build to confirm provider rendering and platform modal behavior.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 82ab2896-d04e-426a-aacf-aaa1bb8e0b7b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@milind-soni
milind-soni marked this pull request as ready for review August 21, 2026 05:08
@milind-soni
milind-soni merged commit 30343a9 into main Aug 21, 2026
6 checks passed
@milind-soni
milind-soni deleted the codex/in-app-vnc-control branch August 21, 2026 05:08
kargnas added a commit to kargnas/OpenMausBot that referenced this pull request Aug 21, 2026
main의 milind-soni#322(인앱 VNC), milind-soni#250(분석 옵트아웃) 병합 충돌을 해결했다.
index.test은 modelSelection 검증 테스트와 팀 프로젝트 임포트
테스트를 모두 유지했다. 새 pi 드라이버는 catalog 계약에 맞춰
default를 {model} 객체로 두고 getter 대신 catalog()를 노출한다.

Tested: pnpm typecheck, pnpm vitest run (139 files, 1392 passed, 12 skipped)

Confidence: high
Scope-risk: moderate
Reversability: moderate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant