Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Rework shortcodes to align with the community and support localization. #64

Merged
merged 19 commits into from
Aug 15, 2020

Conversation

milesj
Copy link
Owner

@milesj milesj commented Aug 11, 2020

This has been a rather large topic but I believe we have a path forward.

Solves #49, #51, #52, #53, #57

  • Remove shortcodes from existing datasets.
  • Remove meta/shortcodes.json dataset.
  • Add localized shortcodes based on CLDR annotations.
  • Add shortcode presets: emojibase, slack, github, etc.
  • Update APIs to merge multiple presets into a single dataset.
  • Update regex/shortcode to support locales.

@milesj
Copy link
Owner Author

milesj commented Aug 15, 2020

@strixaluco This is ready. Would you be able to test it if I published a pre-release?

@milesj milesj marked this pull request as ready for review August 15, 2020 01:05
@milesj milesj merged commit be28be6 into master Aug 15, 2020
@milesj milesj deleted the redo-shortcodes branch August 15, 2020 01:55
@strixaluco
Copy link

@milesj Thanks for such a prompt rework. I'll do my best to do the testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants