Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Cint to Clong to handle 64-bit sizes #23

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Change Cint to Clong to handle 64-bit sizes #23

merged 1 commit into from
Nov 28, 2023

Conversation

jkwashbourne-oss
Copy link
Contributor

Fixes #22

@milankl
Copy link
Owner

milankl commented Nov 28, 2023

Looks good, do you need this as a new tagged release?

@jkwashbourne-oss
Copy link
Contributor Author

A new release would be great, but no rush. I need to figure out what the branch syntax is here tho ZfpCompression#patch-1 is not right.

@jkwashbourne-oss
Copy link
Contributor Author

maybe I do need a release ...

@milankl
Copy link
Owner

milankl commented Nov 28, 2023

Your branch is still at jkwashbourne-oss:patch-1 once I merge it's also in #master

@milankl milankl merged commit 0c7ec42 into milankl:master Nov 28, 2023
1 check passed
@jkwashbourne-oss
Copy link
Contributor Author

I was trying to do add ZfpCompression#branch

thanks much for the quick help! really appreciate it. just ran into this when we moved to a larger problem with ensembles of size 433,000 x 8001.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milankl milankl milankl approved these changes

Assignees
No one assigned
Labels
compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

64 bit pointers?
2 participants
@jkwashbourne-oss @milankl