Check cli version match only for running pods

Fixes linkerd#11280 Signed-off-by: Takumi Sue <[email protected]>
mikutas · Aug 25, 2023 · 58905f0 · 58905f0
1 parent a4bec90
commit 58905f0
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/healthcheck/healthcheck.go b/pkg/healthcheck/healthcheck.go
@@ -1450,9 +1450,12 @@ func CheckProxyVersionsUpToDate(pods []corev1.Pod, versions version.Channels) er
 // matches that of the CLI
 func CheckIfProxyVersionsMatchWithCLI(pods []corev1.Pod) error {
 	for _, pod := range pods {
-		proxyVersion := k8s.GetProxyVersion(pod)
-		if proxyVersion != "" && proxyVersion != version.Version {
-			return fmt.Errorf("%s running %s but cli running %s", pod.Name, proxyVersion, version.Version)
+		status := k8s.GetPodStatus(pod)
+		if status == string(corev1.PodRunning) && containsProxy(pod) {
+			proxyVersion := k8s.GetProxyVersion(pod)
+			if proxyVersion != "" && proxyVersion != version.Version {
+				return fmt.Errorf("%s running %s but cli running %s", pod.Name, proxyVersion, version.Version)
+			}
 		}
 	}
 	return nil