Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.5.5 doesn't support "extends": "@tsconfig/node12/tsconfig.json", #1849

Closed
zxxc opened this issue May 24, 2021 · 2 comments · Fixed by #1854
Closed

4.5.5 doesn't support "extends": "@tsconfig/node12/tsconfig.json", #1849

zxxc opened this issue May 24, 2021 · 2 comments · Fixed by #1854
Assignees

Comments

@zxxc
Copy link

zxxc commented May 24, 2021

Describe the bug
I updated from 4.5.4 to 4.5.5 and migrations stopped working

Stack trace

> node node_modules/.bin/mikro-orm migration:up

(node:12927) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/Users/aklamer/Documents/GitHub/integrationhub/@tsconfig/node12/tsconfig.json'
(node:12927) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:12927) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

tsconfig:

{
  "extends": "@tsconfig/node12/tsconfig.json",
  "compilerOptions": {
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "types": ["mocha"],
    "sourceMap": true
  },
  "exclude": ["node_modules"]
}

To Reproduce
Steps to reproduce the behavior:

  1. npm install @tsconfig/node12 --save-dev
  2. use tsconfig from example above with extends
  3. use mikro-orm 4.5.5
  4. try to apply migrations

Expected behavior
Successfully migrated up to the latest version

Additional context
Add any other context about the problem here.

Versions

 "@mikro-orm/core": "4.5.5",
    "@mikro-orm/migrations": "4.5.5",
    "@mikro-orm/postgresql": "4.5.5",
   "@mikro-orm/cli": "4.5.5",
    "@tsconfig/node12": "^1.0.7",
 "typescript": "^4.2.4"
node -v: v12.16.3```
@B4nan
Copy link
Member

B4nan commented May 24, 2021

cc @Langstra this is probably caused by the change you did

Langstra added a commit to RiskChallenger/mikro-orm that referenced this issue May 24, 2021
This way the extended property of the tsconfig file can be read
property.

Fixes mikro-orm#1849
Langstra added a commit to RiskChallenger/mikro-orm that referenced this issue May 25, 2021
This way the extended property of the tsconfig file can be read
property.

Fixes mikro-orm#1849
Langstra added a commit to RiskChallenger/mikro-orm that referenced this issue May 25, 2021
This way the extended property of the tsconfig file can be read
property.

Fixes mikro-orm#1849
Langstra added a commit to RiskChallenger/mikro-orm that referenced this issue May 25, 2021
This way the extended property of the tsconfig file can be read
property.

Fixes mikro-orm#1849
Langstra added a commit to RiskChallenger/mikro-orm that referenced this issue May 26, 2021
This way the extended property of the tsconfig file can be read
properly

Fixes mikro-orm#1849
B4nan pushed a commit that referenced this issue May 28, 2021
This way the extended property of the tsconfig file can be read
property.

Fixes #1849
B4nan pushed a commit that referenced this issue May 29, 2021
This way the extended property of the tsconfig file can be read
property.

Fixes #1849
@B4nan
Copy link
Member

B4nan commented May 29, 2021

4.5.6-dev.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants