fix(migrations): ensure executedAt is a Date when listing executed …

…migrations This fixes usage of `migration:list` in SQLite. Closes #2817
mikro-orm · Feb 25, 2022 · c8753ee · c8753ee
1 parent f2b09f5
commit c8753ee
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/migrations/src/MigrationStorage.ts b/packages/migrations/src/MigrationStorage.ts
@@ -42,7 +42,15 @@ export class MigrationStorage implements UmzugStorage {
       qb.transacting(this.masterTransaction);
     }
 
-    return this.connection.execute<MigrationRow[]>(qb);
+    const res = await this.connection.execute<MigrationRow[]>(qb);
+
+    return res.map(row => {
+      if (typeof row.executed_at === 'string') {
+        row.executed_at = new Date(row.executed_at);
+      }
+
+      return row;
+    });
   }
 
   async ensureTable(): Promise<void> {

diff --git a/tests/features/migrations/Migrator.sqlite.test.ts b/tests/features/migrations/Migrator.sqlite.test.ts
@@ -190,7 +190,9 @@ describe('Migrator (sqlite)', () => {
 
     await storage.ensureTable(); // creates the table
     await storage.logMigration({ name: 'test', context: null });
-    await expect(storage.getExecutedMigrations()).resolves.toMatchObject([{ name: 'test' }]);
+    const executed = await storage.getExecutedMigrations();
+    expect(executed).toMatchObject([{ name: 'test' }]);
+    expect(executed[0].executed_at).toBeInstanceOf(Date);
     await expect(storage.executed()).resolves.toEqual(['test']);
 
     await storage.ensureTable(); // table exists, no-op